8000 ZWave: Add reset service to meters by turbokongen · Pull Request #7676 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ZWave: Add reset service to meters 8000 #7676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2017
Merged

ZWave: Add reset service to meters #7676

merged 3 commits into from
May 21, 2017

Conversation

turbokongen
Copy link
Contributor
@turbokongen turbokongen commented May 20, 2017 •
edited
Loading

Description:

This adds a reset_node_meters service to zwave that can let the user reset values in the command_class_meter class. (I.e. kWh meter) This "button" will be present at index 33 of the values if the node supports it.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2674

@mention-bot
Copy link

@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @andrey-git and @armills to be potential reviewers.

@turbokongen turbokongen mentioned this pull request May 20, 2017
Merged
@andrey-git
Copy link
Contributor

Why index 33? Could you point to documentation?

@turbokongen
Copy link
Contributor Author

https://github.com/OpenZWave/open-zwave/blob/master/cpp/src/command_classes/Meter.cpp#L344-L355
Which points to: https://github.com/OpenZWave/open-zwave/blob/master/cpp/src/command_classes/Meter.cpp#L66

andrey-git
andrey-git approved these changes May 20, 2017
View reviewed changes
Copy link
Contributor
@andrey-git andrey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. This is ugly :(

@emlove
Copy link
Contributor
emlove commented May 20, 2017 •
edited
Loading

Even though it looks like we'll only ever have the one, I think it's probably worth adding to zwave/const.py as METER_RESET_INDEX or something like that. At least then it can have a name. Otherwise LGTM.

@turbokongen
Copy link
Contributor Author

You cant reset only one index of the command class. The button resets all meters of the instance.

@emlove
Copy link
Contributor
emlove commented May 20, 2017 •
edited
Loading

I just meant adding METER_RESET_INDEX = 33 to zwave/const.py, and then referencing that instead of just 33 in here. Just to give it a name that mirrors this.

@turbokongen turbokongen merged commit 4a0d6e7 into home-assistant:dev May 21, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emlove emlove emlove approved these changes

@andrey-git andrey-git andrey-git approved these changes

Assignees
No one assigned
Labels
cla-signed integration: zwave platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@turbokongen @mention-bot @andrey-git @emlove @balloobbot @homeassistant
0