Use expected behvaior for above/below #7857 8000
Conversation
|
I'm not a too big fan of adding |
|
Going to merge this, if we want to do min/max it can go in another PR. |
|
@balloob - when this is integrated in to a release can it be marked as a breaking change please? Reason I ask: I currently have a number of automations using the haveibeenpwned sensor, the alert is set to go off when the sensor reading is I suspect that a number of people will be in this boat for one reason or another. I appreciate it's not an actual breaking change, but it is important that people know to change this number if it is critical to their automations/scripts/etc, and I only know about it because I commented in this thread, many other users won't. |
|
@mf-social We do have the PR flagged with the "Breaking Change" label. It will be included in the release notes. I definitely agree is a breaking change that people need to know about. @balloob Agree 100% with the notes about min/max. |
Description:
This PR makes the above/below conditions/triggers not treat equal as a match. This is what would be expected from the words above/below.
We are also considering adding new keywords min/max that use the old behavior, where an equal value is included. These are almost but not exactly the same. I'd like to get some opinions whether it's worth introducing the new keywords or not.
Related issue (if applicable): fixes #7170
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):