8000 Fix moving average for 0 values by daanbeverdam · Pull Request #80476 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix moving average for 0 values 8000 #80476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix moving average for 0 values #80476

merged 1 commit into from
Nov 17, 2022

Conversation

daanbeverdam
Copy link
Contributor
@daanbeverdam daanbeverdam commented Oct 17, 2022 •
edited
Loading

Proposed change

This fixes a bug in the moving average filter where 0 values are disregarded. An example of this behavior can be seen below. When I turn off my espresso machine and power consumption goes to 0 watt, the filtered (moving average) value stays at the last seen value.

Screenshot 2022-10-17 at 19 17 42

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@daanbeverdam daanbeverdam requested a review from dgomes as a code owner October 17, 2022 17:29
@home-assistant
Copy link

Hi daanbeverdam

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (filter) you are listed as a code owner for? Thanks!

@dgomes dgomes added this to the 2022.11.4 milestone Nov 17, 2022
frenck
frenck approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @daanbeverdam 👍

@frenck frenck merged commit f82c4c7 into home-assistant:dev Nov 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgomes dgomes dgomes approved these changes

@frenck frenck 63AB frenck approved these changes

Assignees

@dgomes dgomes

Labels
bugfix cherry-picked cla-signed Hacktoberfest hacktoberfest-accepted integration: filter Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.11.4
Development

Successfully merging this pull request may close these issues.
4 participants
@daanbeverdam @dgomes @frenck @balloob
0