Use DataUpdateCoordinator in scrape #80593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @fabaff, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( |
epenet
commented
Oct 19, 2022
Comment on lines
+162
to
+168
| mocker.payload = "test_scrape_sensor_no_data" | ||
| async_fire_time_changed(hass, datetime.utcnow() + SCAN_INTERVAL) | ||
| await hass.async_block_till_done() |
|
|
| assert mocker.data is None | ||
| state = hass.states.get("sensor.ha_version") | ||
| assert state is not None | ||
| assert state.state == "Current Version: 2021.12.10" | ||
| assert state.state == STATE_UNAVAILABLE |
There was a problem hiding this comment.
Note: there is a slight change of behavior here.
With the DataCoordinator, we now set the state as UNAVAILABLE, where previously it returned the last value.
gjohansson-ST
approved these changes
Oct 22, 2022
emontnemery
approved these changes
Oct 24, 2022
Djelibeybi
pushed a commit
to Djelibeybi/home-assistant-core
that referenced
this pull request
Oct 24, 2022
* Add DataUpdateCoordinator to scrape * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Previous implementation of scrape would return the last correct value if the http request failed.
This has been adjusted to now mark the sensor as
unavailable.Proposed change
Use
DataUpdateCoordinatorinscrapeLinked to #74325
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: