8000 Allow hostname for nibe heatpump by elupus · Pull Request #80793 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow hostname for nibe heatpump #80793

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

Allow hostname for nibe heatpump #80793

merged 1 commit into from
Oct 24, 2022

Conversation

elupus
Copy link
Contributor
@elupus elupus commented Oct 22, 2022

Proposed change

Allow specifying a hostname like a mdns name of a esphome device instead of a fixed IP address.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

davet2001
davet2001 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor
@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Obviously this leaves config keys still as 'ip_address' etc, but if they are not user facing this should not be a major issue.

@elupus elupus merged commit ebfb10c into home-assistant:dev Oct 24, 2022
@elupus elupus deleted the nibe/allowhost branch October 24, 2022 12:17
StevenLooman pushed a commit to StevenLooman/home-assistant that referenced this pull request Oct 24, 2022
@elupus @StevenLooman
Allow hostname for nibe heatpump (home-assistant#80793)
eb6b7dd 
Allow hostname for nibe
Djelibeybi pushed a commit to Djelibeybi/home-assistant-core that referenced this pull request Oct 24, 2022
@elupus @Djelibeybi
Allow hostname for nibe heatpump ( 7EB4 home-assistant#80793)
208f224 
Allow hostname for nibe
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed Hacktoberfest has-tests integration: nibe_heatpump new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elupus @davet2001
0