Refactor zwave_js add-on manager #80 8000 883
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| to keep track of running add-on tasks. | ||
| """ | ||
|
|
||
| def __init__(self, hass: HomeAssistant) -> None: | ||
| def __init__(self, hass: HomeAssistant, addon_name: str, addon_slug: str) -> None: |
There was a problem hiding this comment.
Should we include a minimum version that we want the add-on to have or are we always going to push for latest possible?
There was a problem hiding this comment.
This is just a refactor. I haven't planned to add any new features here. That's something that can be discussed separately.
There was a problem hiding this comment.
A minimum version could be used to check if we have the required version. When we update though, I think we always want to go to the latest version. But I haven't thought about specific cases for other integrations yet. So I'll leave it at that for now.
There was a problem hiding this comment.
I guess the max version is already set by the addon having a min HA version. So HA can just go to latest.
* Make addon slug an instance attribute * Extract addon name and addon config * Update docstrings
* Make addon slug an instance attribute * Extract addon name and addon config * Update docstrings
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: