8000 Add "Push Flow Meter Data" service to RainMachine and bump regenmaschine to 2022.10.0 by shbatm · Pull Request #80890 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add "Push Flow Meter Data" service to RainMachine and bump regenmaschine to 2022.10.0 #80890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2022
Merged

Add "Push Flow Meter Data" service to RainMachine and bump regenmaschine to 2022.10.0 #80890

merged 8 commits into from
Oct 24, 2022

Conversation

shbatm
Copy link
Contributor
@shbatm shbatm commented Oct 24, 2022 •
edited by bachya
Loading

Proposed change

Add new service to RainMachine to push flow meter data from an external device to the RainMachine controller.

This functionality was added in RainMachine API 4.6.1

regenmaschine @ 2022.10.0:
Changelog: bachya/regenmaschine@2022.10.0 (release)
Diff: bachya/regenmaschine@2022.09.2...2022.10.0

Note: adding the flow meter data as sensors will be subject of a future PR. Splitting these for ease of review.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration (rainmachine) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainmachine can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign rainmachine Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bachya
Copy link
Contributor
bachya commented Oct 24, 2022

FYI, just cut regenmaschine 2022.10.0

Changelog: https://github.com/bachya/regenmaschine/releases/tag/2022.10.0
Diff: bachya/regenmaschine@2022.09.2...2022.10.0

@shbatm shbatm changed the title Add "Push Flow Meter Data" service to RainMachine and bump regenmaschine to 2022.09.2 Add "Push Flow Meter Data" service to RainMachine and bump regenmaschine to 2022.10.0 Oct 24, 2022
@shbatm shbatm closed this Oct 24, 2022
@shbatm shbatm reopened this Oct 24, 2022
@shbatm shbatm mentioned this pull request Oct 24, 2022
Merged
8 tasks
@shbatm shbatm marked this pull request as ready for review October 24, 2022 15:19
@shbatm shbatm requested a review from bachya as a code owner October 24, 2022 15:19
bachya
bachya reviewed Oct 24, 2022
View reviewed changes
@shbatm
Copy link
Contributor Author
shbatm commented Oct 24, 2022

@bachya I think I caught everything in the update. Let me know if you see anything else. Thanks for the review.

@bachya
Copy link
Contributor
bachya commented Oct 24, 2022

@shbatm Looks great! I don't have a flow meter, so I can't directly test this – have you confirmed?

@shbatm
Copy link
Contributor Author
shbatm commented Oct 24, 2022

@bachya - don't approve yet. Chasing this error from the unit:

2022-10-24 11:29:06,983 - ERROR - rmHTTPResourceApi4Watering:421 - int() argument must be a string or a number, not 'dict'

@shbatm
Copy link
Contributor Author
shbatm commented Oct 24, 2022 •
edited
Loading

@bachya Fixed. The service is functioning properly, but the flow meter sensors in HA that are part of the existing integration aren't reading anything for Flow Sensor Clicks or Flow Sensor Start Index, only clicks per m^3 works correctly--still from the old API; I'll work on the follow up PR when I get a chance..

image

image

bachya
bachya requested changes Oct 24, 2022
View reviewed changes
bachya
bachya reviewed Oct 24, 2022
View reviewed changes
bachya
bachya reviewed Oct 24, 2022
View reviewed changes
bachya
bachya approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor
@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 24, 2022
@bachya bachya merged commit ac4645a into home-assistant:dev Oct 24, 2022
@shbatm shbatm deleted the rainmachine_add_flow_meter_service branch October 24, 2022 19:52
StevenLooman pushed a commit to StevenLooman/home-assistant that referenced this pull request Oct 24, 2022
@shbatm @StevenLooman
Add "Push Flow Meter Data" service to RainMachine and bump regenmasch…
6912d9f 
…ine to 2022.10.0 (home-assistant#80890)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bachya bachya bachya approved these changes

Assignees

@bachya bachya

Labels
cla-signed Hacktoberfest integration: rainmachine new-feature Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shbatm @bachya @frenck
0