8000 Fix SSDP/UPnP server after testing by StevenLooman · Pull Request #80815 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix SSDP/UPnP server after testing #80 8000 815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2022
Merged

Fix SSDP/UPnP server after testing #80815

merged 6 commits into from
Oct 24, 2022

Conversation

StevenLooman
Copy link
Contributor
@StevenLooman StevenLooman commented Oct 23, 2022 •
edited
Loading

Proposed change

Fixes after testing by @oyvindwe the new ssdp/upnp server. Includes a fix for the race condition reported in #80400 as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Changes to async-upnp-client 0.32.1:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@StevenLooman StevenLooman marked this pull request as draft October 23, 2022 11:07
@StevenLooman
Copy link
Contributor Author

Converted to draft, as async-upnp-client needs to be released as well.

@MartinHjelmare MartinHjelmare changed the title Fixes for SSDP/UPnP server after testing Fix SSDP/UPnP server after testing Oct 23, 2022
@oyvindwe oyvindwe mentioned this pull request Oct 23, 2022
Closed
@StevenLooman StevenLooman marked this pull request as ready for review October 23, 2022 19:00
@StevenLooman StevenLooman mentioned this pull request Oct 23, 2022
Merged
23 tasks
@oyvindwe
Copy link
Contributor

I have verified that HTTP and SSDP servers starts on macOS with this change. I also see incoming and outgoing communication on SSDP multicast on both IPv4 and IPv6, both for discovery and for the server, and I can reach the HTTP servers on both IPv4 and IPv6.

bdraco
bdraco reviewed Oct 24, 2022
View reviewed changes
@bdraco
Copy link
Member
bdraco commented Oct 24, 2022

Tested and verified the reported race is gone on macos and linux

bdraco
bdraco approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question above #80815 (comment)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 24, 2022
bdraco
bdraco approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested 👍

@bdraco bdraco merged commit b5f70a4 into home-assistant:dev Oct 24, 2022
@StevenLooman
Copy link
Contributor Author

Great, thanks!

@StevenLooman StevenLooman deleted the ssdp_upnp_server_fixes branch October 24, 2022 20:35
StevenLooman added a commit to StevenLooman/home-assistant that referenced this pull request Oct 24, 2022
@StevenLooman
Fix SSDP/UPnP server after testing (home-assistant#80815)
185c005
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

@epenet epenet Awaiting requested review from epenet epenet is a code owner

Assignees
No one assigned
Labels
bugfix cla-signed dependency Hacktoberfest integration: ssdp Quality Scale: internal small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race in new Home Assistant discoverable via SSDP
4 participants
@StevenLooman @oyvindwe @bdraco @frenck
0