10000 Fix homekit_controller climate entity not becoming active when changing modes by Jc2k · Pull Request #81868 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix homekit_controller climate entity not becoming active when changing modes #81868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix homekit_controller climate entity not becoming active when changing modes #81868

merged 1 commit into from
Nov 9, 2022

Conversation

Jc2k
Copy link
Member
@Jc2k Jc2k commented Nov 9, 2022 •
edited by bdraco
Loading

Proposed change

When we turn a device off, we set the mode from ACTIVE to INACTIVE. We never turned it back on. Probably some devices were automatically marking a device as active when you change modes, but that behaviour is not universal.

replaces and closes #78725

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Jc2k Jc2k requested a review from bdraco as a code owner November 9, 2022 14:59
@home-assistant
Copy link
home-assistant bot commented Nov 9, 2022

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the issue, add the integration domain after the command.

@Jc2k Jc2k added this to the 2022.11.3 milestone Nov 9, 2022
@Jc2k Jc2k changed the title Fix leaving homekit_controller device in inactive state when changing modes Fix homekit_controller climate entity not becoming active when changing modes Nov 9, 2022
@bdraco
Copy link
Member
bdraco commented Nov 9, 2022

Added replaces and closes https://github.com/home-assistant/core/pull/78725 to the opening text so merging this will take care of that as well

@Jc2k Jc2k mentioned this pull request Nov 9, 2022
Closed
19 tasks
@Jc2k Jc2k merged commit 9de4d7c into home-assistant:dev Nov 9, 2022
@Jc2k Jc2k deleted the homekit_controller_81863 branch November 9, 2022 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: homekit_controller Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.11.3
Development

Successfully merging this pull request may close these issues.

Problem turning heat back on in Aqara Smart Thermostat E1
3 participants
@Jc2k @bdraco @frenck
0