8000 Revert google calendar back to old API for free/busy readers by allenporter · Pull Request #81894 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert google ca 8000 lendar back to old API for free/busy readers #81894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

Revert google calendar back to old API for free/busy readers #81894

merged 2 commits into from
Nov 10, 2022

Conversation

allenporter
Copy link
Contributor
@allenporter allenporter commented Nov 10, 2022 •
edited
Loading

Proposed change

Revert google calendar back to old API when a calendar is only exposed free/busy readers. When using the new sync API, free/busy readers are exposed as denormalized single events rather than a single event with a recurrence rule. As a result, sync pulls down too much data in the future -- so we'll just go back to the old behavior and not get the performance wins for free/busy.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2022.11.3 milestone Nov 10, 2022
MartinHjelmare
MartinHjelmare reviewed Nov 10, 2022
View reviewed changes
@allenporter @MartinHjelmare
Update homeassistant/components/google/calendar.py
a7c34fb 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@allenporter allenporter merged commit e6d1a4a into home-assistant:dev Nov 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: google Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.11.3
Development

Successfully merging this pull request may close these issues.

Google Calendar integration fetches all events for free busy reader
3 participants
@allenporter @MartinHjelmare @frenck
0