8000 Bump PyViCare to 2.19.0 by TheJulianJES · Pull Request #82381 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump PyViCare to 2.19.0 #82381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2022
Merged

Bump PyViCare to 2.19.0 #82381

merged 1 commit into from
Nov 20, 2022

Conversation

TheJulianJES
Copy link
Member
@TheJulianJES TheJulianJES commented Nov 19, 2022 •
edited
Loading

Proposed change

Bumps PyViCare to 2.19.0
Changes: openviess/PyViCare@2.17.0...2.19.0

Fixes:

Maybe this should also be included in 2022.11.4 (or the next hot-fix release)?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @oischinger, mind taking a look at this pull request as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vicare can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign vicare Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco added this to the 2022.11.4 milestone Nov 19, 2022
@bdraco bdraco changed the title Bump PyViCare==2.19.0 Bump PyViCare to 2.19.0 Nov 19, 2022
@bdraco bdraco merged commit ea0c3e8 into home-assistant:dev Nov 20, 2022
balloob pushed a commit that referenced this pull request Nov 20, 2022
@TheJulianJES @balloob
Bump PyViCare to 2.19.0 (#82381)
5ec7cff 
fixes undefined
@balloob balloob mentioned this pull request Nov 20, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed dependency dependency-bump integration: vicare Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.11.4
Development

Successfully merging this pull request may close these issues.

ViCare API rate limit exceeded with default scan_interval
3 participants
@TheJulianJES @bdraco @balloob
0