8000 Prevent powerwall from switching addresses if its online by bdraco · Pull Request #82410 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent powerwall from switching addresses if its online #82410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2022
Merged

Prevent powerwall from switching addresses if its online #82410

merged 5 commits into from
Nov 20, 2022

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Nov 20, 2022 •
edited
Loading

Proposed change

If the wifi interface was discovered we would switch the ip address in the entry to the wifi ip even if it was connected via ethernet. The wifi interface is flakey on these and once it switched it would sometimes go offline forcing the user to re-add it with the ethernet ip to get it back up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Prevent powerwall from switching addresses if its online
7a1305f 
If the wifi interface was discovered we would switch the
ip address in the entry to the wifi ip even if it was
connected via ethernet
@home-assistant
Copy link

Hey there @jrester, mind taking a look at this pull request as it has been labeled with an integration (powerwall) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of powerwall can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign powerwall Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco added this to the 2022.11.4 milestone Nov 20, 2022
@bdraco bdraco marked this pull request as ready for review November 20, 2022 13:47
@balloob balloob merged commit a1d9d71 into home-assistant:dev Nov 20, 2022
@bdraco
Copy link
Member Author
bdraco commented Nov 20, 2022

thanks

balloob pushed a commit that referenced this pull request Nov 20, 2022
@bdraco @balloob
Prevent powerwall from switching addresses if its online (#82410)
3ab1df4 
* Prevent powerwall from switching addresses if its online

If the wifi interface was discovered we would switch the
ip address in the entry to the wifi ip even if it was
connected via ethernet

* cover

* more cover
@balloob balloob mentioned this pull request Nov 20, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: powerwall Quality Scale: No score
Projects
None yet
Milestone
2022.11.4
Development

Successfully merging this pull request may close these issues.

Tesla Powerwall integration continuosly loses connectivity with the tesla gateway Powerwall integration lost connection to PW and didn't reconnect
2 participants
@bdraco @balloob
0