8000 Accept transition for light.toggle by amelchio · Pull Request #8466 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accept transition for light.toggle #8466 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

amelchio
Copy link
Contributor

Description:

I don't know how to write a test for this because the demo light does not support transitions.

Related issue (if applicable): fixes #8459

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully.
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@amelchio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @fabaff to be potential reviewers.

@cmsimike
Copy link
Contributor

Thank you so much for this quick fix!!

@balloob balloob added this to the 0.49 milestone Jul 14, 2017
@balloob balloob merged commit 87b83f3 into home-assistant:dev Jul 14, 2017
balloob pushed a commit that referenced this pull request Jul 16, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

light.toggle doesn't seem to accept transition
6 participants
0