Fix hue lights for Philips and non-philips lights
#8905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@groth-its, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @michaelarnauts to be potential reviewers. |
houndci-bot
reviewed
Aug 9, 2017
| elif self.bridge_type == 'hue': | ||
| if self.info.get('manufacturername') != "OSRAM": | ||
| command['effect'] = 'none' | ||
| elif self.bridge_type == 'hue' and self.info.get('manufacturername') == 'Philips': |
amelchio
reviewed
Aug 10, 2017
| @@ -384,7 +384,7 @@ def turn_on(self, **kwargs): | |||
| hue, sat = color_util.color_xy_to_hs(*kwargs[ATTR_XY_COLOR]) | |||
| command['hue'] = hue | |||
| command['sat'] = sat | |||
| command['bri'] = self.info['bri'] | |||
| command['bri'] = self.info.get('bri') | |||
There was a problem hiding this comment.
I think this is setting the brightness to the value that HA has cached, right? Can we simply delete the line and the bulb will maintain the current brightness (but change its hue and saturation)?
There was a problem hiding this comment.
Valid point, thanks a lot. I took care of that.
|
Thanks 🐬 |
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes coding errors for getting current brightness state introduced when making the component compatible to OSRAM lights (#6122).
Since the original issue addressed in #6122 for OSRAM lights is also true for innr lights (they don't handle "effect": "none"), I decided to only set this parameter when a Philips light is controlled.
Lastly makes color temperature, xy and rgb all mutual exclusive.
Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass