8000 Update python-wink version to fix Dome water valve bug. by w1ll1am23 · Pull Request #8923 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update python-wink version to fix Dome water va 8000 lve bug. #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2017
Merged

Update python-wink version to fix Dome water valve bug. #8923

merged 1 commit into from
Aug 11, 2017

Conversation

w1ll1am23
Copy link
Contributor
@w1ll1am23 w1ll1am23 commented Aug 11, 2017 •
edited
Loading

Description:

Fixed a bug in python-wink preventing the Dome main water valve from working.

Related issue (if applicable): fixes https://community.home-assistant.io/t/dome-water-main-switch-via-wink/24106/2

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running

@mention-bot
Copy link

@w1ll1am23, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

@w1ll1am23 w1ll1am23 added this to the 0.50.3 milestone Aug 11, 2017
fabaff
fabaff approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member
@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff modified the milestones: 0.51, 0.50.3 Aug 11, 2017
@fabaff fabaff merged commit d427063 into home-assistant:dev Aug 11, 2017
balloob pushed a commit that referenced this pull request Aug 12, 2017
@balloob
Update python-wink version to fix Dome water valve bug. (#8923)
08899ad
@fabaff fabaff mentioned this pull request Aug 12, 2017
Merged
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@dethpickle
Update python-wink version to fix Dome water valve bug. (home-assista…
c27be3a 
…nt#8923)
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
@ghost ghost removed the platform: switch.wink label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed component integration: wink platform requirement
Projects
None yet
Milestone
0.51
Development

Successfully merging this pull request may close these issues.
5 participants
@w1ll1am23 @mention-bot @fabaff @balloobbot @homeassistant
0