8000 Fix call to ha_send_commands by MartinHjelmare · Pull Request #8956 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix call to ha_send_commands #8956

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2017

Conversation

MartinHjelmare
Copy link
Member
@MartinHjelmare MartinHjelmare commented Aug 13, 2017

Description:

  • Name keyword arguments correctly according to dependency lib.
  • Only pass keyword arguments that are not None.

Related issue (if applicable):
fixes #8944

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.
@mention-bot
Copy link

@MartinHjelmare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @tony2nite to be potential reviewers.

@MartinHjelmare MartinHjelmare added this to the 0.51.2 milestone Aug 13, 2017
@balloob balloob merged commit cbe5225 into home-assistant:dev Aug 13, 2017
balloob pushed a commit that referenced this pull request Aug 14, 2017
* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.
@balloob balloob mentioned this pull request Aug 14, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.
@MartinHjelmare MartinHjelmare deleted the fix-harmony-call branch September 3, 2017 19:55
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending commands through Logitech Harmony Hub remote does not work after update to 0.51
5 participants
0