Nello.io lock support #8957
Merged
Nello.io lock support #8957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pschmitt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
emlove
reviewed
Aug 13, 2017
| # Save the activity history so that we don't trigger an event twice | ||
| self._activity = activity | ||
|
|
||
| def unlock(self, **kwargs): |
There was a problem hiding this comment.
This method is a little confusing. Isn't self._locked always going to be reset to True before this method exits?
There was a problem hiding this comment.
Yes. See 55ef048
emlove
approved these changes
Aug 13, 2017
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Initial Nello.io lock support * Log an error when unlocking failed * Make the lock's state always locked
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Nello.io are cloud-based intercom solutions that allow to buzz open the door in apartment buildings and receive notifications when someone rings the bell.
This here presents a new
lockdevice that does not implement thelockfunction ;)It also fires a
nello_bell_ringevent when the bell has been rung.Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3173
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.