Fix issue 8894 with uk_transport component if no next_buses or next_trains #9046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, how the "no more trains/bus" renders on the front-end? The |
balloob
reviewed
Aug 23, 2017
| _delta_mins, [bus['scheduled'] for bus in self._next_buses] | ||
| )) | ||
| else: | ||
| self._state = STATE_UNKNOWN |
There was a problem hiding this comment.
Please don't use STATE_UNKNOWN, instead set it to None
balloob
reviewed
Aug 23, 2017
| [train['scheduled'] for train in self._next_trains] | ||
| )) | ||
| if self._next_trains: | ||
| self._state = min(map( |
There was a problem hiding this comment.
You can merge the map into the list comprehension:
min(_delta_mins(train['scheduled']) for train in self._next_trains)
balloob
reviewed
Aug 23, 2017
| [train['scheduled'] for train in self._next_trains] | ||
| )) | ||
| else: | ||
| self._state = STATE_UNKNOWN |
|
Awesome, thanks! 🐬 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8894
Description:
Fixes #8894 where an error was thrown if there were no next-buses or trains
Related issue (if applicable): fixes #8894
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass