8000 Simplisafe unknown status fix by lekobob · Pull Request #9111 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplisafe unknown status fix #9111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Simplisafe unknown status fix #9111

merged 2 commits into from
Aug 24, 2017

Conversation

lekobob
Copy link
Contributor
@lekobob lekobob commented Aug 24, 2017

Description:

Related issue (if applicable): fixes #9097

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Changed simplisafe-python requirement to 1.0.5 and changed state return
case statements to lower case
@homeassistant
Copy link
Contributor

Hi @lekobob,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot
Copy link

@lekobob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @w1ll1am23 to be potential reviewers.

Copy link
Member
@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 698d133 into home-assistant:dev Aug 24, 2017
@balloob balloob mentioned this pull request Aug 25, 2017
@lekobob lekobob deleted the simplisafe-unknown-status-fix branch August 27, 2017 06:42
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplisafe status unknown
4 participants
0