Fix # 8000 863 - Added a check for good pull from OWM and return if the object is None #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn if the object is None
|
Related #863 |
|
🐬 |
balloob
added a commit
that referenced
this pull request
Jan 21, 2016
Fix #863 - Added a check for good pull from OWM and return if the object is None
|
Thanks @zmrow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the OWM API returns an empty or None response, we will log the error and return. The sensor will refresh at another time.
Possible future enhancement is to overrule the
@Throttledecorator to retry, but probably not necessary at this time. (I couldn't get it to fail unless I deliberately did something dumb)