8000 Migrate esphome alarm_control_panel platform to use _on_static_info_update by bdraco · Pull Request #94961 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate esphome alarm_control_panel platform to use _on_static_info_update #94961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

Migrate esphome alarm_control_panel platform to use _on_static_info_update #94961

merged 2 commits into from
Jun 26, 2023

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jun 21, 2023 •
edited
Loading

Proposed change

followup to #94930

cc @grahambrown11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Member Author
bdraco commented Jun 21, 2023

@grahambrown11 Since this platform is new, I have nothing to test against. Can you give this a spin?

@bdraco bdraco marked this pull request as ready for review June 22, 2023 23:52
@bdraco
Copy link
Member Author
bdraco commented Jun 22, 2023

added test cover in #95090 and this still passes so undrafting

@grahambrown11
Copy link
Contributor

Since this platform is new, I have nothing to test against

sure I'll check this weekend

@grahambrown11
Copy link
Contributor

@bdraco tested and works like a charm - after changing the ESPHome config and installing HA magically updates the available features, not restarts or funny business required 😄

@bdraco
Copy link
Member Author
bdraco commented Jun 25, 2023

Thanks for testing 🎉

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jun 26, 2023
@bdraco bdraco added this to the 2023.7.0b0 milestone Jun 26, 2023
@bdraco
Copy link
Member Author
bdraco commented Jun 26, 2023

tagging this since its the last one and I'd like to avoid having only one platform different in case there are followup fixes

frenck
frenck approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @bdraco 👍

../Frenck

@frenck frenck merged commit 7737271 into dev Jun 26, 2023
@frenck frenck deleted the esphome_migrate_alarm_control_panel branch June 26, 2023 20:58
@bdraco
Copy link
Member Author
bdraco commented Jun 26, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter is a code owner

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz is a code owner

Assignees

@jesserockz jesserockz

@OttoWinter OttoWinter

Labels
by-code-owner cla-signed code-quality integration: esphome Quality Scale: No s 51CA core small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2023.7.0b0
Development

Successfully merging this pull request may close these issues.
5 participants
@bdraco @grahambrown11 @frenck @jesserockz @OttoWinter
0