Suppress InsecureRequestWarning when verify_ssl is False for camera.synology #9777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 9, 2017
| @@ -44,6 +44,11 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None): | |||
| verify_ssl = config.get(CONF_VERIFY_SSL) | |||
| timeout = config.get(CONF_TIMEOUT) | |||
|
|
|||
| if not verify_ssl: | |||
| from requests.packages import urllib3 | |||
| _LOGGER.warning('InsecureRequestWarning is disabled for camera.synology platform') | |||
|
Also updated CODEOWNERS file as suggested by @andrey-git in #9754 |
andrey-git
approved these changes
Oct 9, 2017
sdague
suggested changes
Oct 9, 2017
| if not verify_ssl: | ||
| from requests.packages import urllib3 | ||
| _LOGGER.warning('InsecureRequestWarning is disabled for camera.synology platform') | ||
| urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) |
There was a problem hiding this comment.
The problem with this is you are disabling ALL warnings for urllib3 across the system. That means things like connections to other web services apis also get disabled. This is really not the right way to do that.
|
I close this while we want do that. Please change your synology settup to work with correct certificate or life with that warnings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
camera.synology is spewing logs like this:
I'm guessing most users are running synology surveillance camera without valid SSL certificate, so this is annoying. The change made is that if user specifically turned off ssl_verify, then we should suppress InsecureRequestWarning as well
Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass