8000 Make host optional by fabaff · Pull Request #10063 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Make host optional #10063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2017
Merged

Make host optional #10063

merged 2 commits into from
Oct 23, 2017

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Oct 23, 2017 •
edited
Loading

Description:

  • Make host optional and set the @ as default to avoid YAML issues. Was not addressed in Add namecheap DNS component #9821.
  • Update docstrings
  • Sync with namecheapdns naming of elements

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3733

Example entry for configuration.yaml (if applicable):

namecheapdns:
  domain: example.com
  password: thePassword

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@fabaff
Copy link
Member Author
fabaff commented Oct 23, 2017

Breaking changes:
The namecheapdns now uses password: instead of access_token in the configuration. Also, host is now optional which allow people who are not using subdomains to keep their configuration shorter.

@fabaff fabaff mentioned this pull request Oct 23, 2017
Merged
@fabaff fabaff merged commit 42e59b4 into dev Oct 23, 2017
@fabaff fabaff deleted the namecheapdns branch October 23, 2017 13:24
@balloob balloob mentioned this pull request Nov 2, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
breaking-change cla-signed component Hacktoberfest integration: namecheapdns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabaff @pvizeli @balloobbot @homeassistant
0