8000 Fix device update / entity_id with names by pvizeli · Pull Request #10029 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix device update / entity_id with names #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2017
Merged

Fix device update / entity_id with names #10029

merged 3 commits into from
Oct 22, 2017

Conversation

pvizeli
Copy link
Member
@pvizeli pvizeli commented Oct 22, 2017 •
edited
Loading

Description:

With #9924 we forgeth that some device need call update before he provide the name that we read by generate_entity_id.

This PR call now the update like before but care about the PARALLEL_UPDATES settings of the platform. We do now also protect the add device callback if the update will raise a exception we don't break the hole platform like before. I remove also the update code inside add_entities and add a warning. We use this function now only inside tests and there we can't run into a deadlock and for custom component it's very hard to run into a real deadlock with new code. So we reduce a logic there.

Fix: #10028
Fix: #10015
Fix: #10018
Fix: #10020

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@pvizeli pvizeli requested a review from a team as a code owner October 22, 2017 13:12
@pvizeli pvizeli added this to the 0.56.1 milestone Oct 22, 2017
@balloob balloob merged commit 56cbfb5 into dev Oct 22, 2017
@balloob balloob deleted the fix-name-entity-id branch October 22, 2017 15:40
balloob pushed a commit that referenced this pull request Oct 22, 2017
@pvizeli @balloob
Fix device update / entity_id with names (#10029)
98324b3 
* Fix device update

* Add tests

* add test for disabled warning
@vittoriom
Copy link
Contributor

That was quick! Thanks a lot, hope this will go to a 0.56.1 👍

@balloob balloob mentioned this pull request Oct 22, 2017
Merged
@emlove emlove mentioned this pull request Oct 22, 2017
Merged
@bachya
Copy link
Contributor
bachya commented Oct 22, 2017

Thanks guys. For future reference, I assume that if an update doesn't go out right away, we can monkeypatch these files into our installations via custom_components?

pvizeli pushed a commit that referenced this pull request Oct 22, 2017
@balloob @pvizeli
0.56.1 (#10035)
106bf46 
* Version bump to 0.56.1

* Fix device update / entity_id with names (#10029)

* Fix device update

* Add tests

* add test for disabled warning

* fix temperature/humidity sensors valid values (#10024)
@balloob
Copy link
Member
balloob commented Oct 22, 2017

Not in this case because it was a bug in a core part and not a built-in component.

This fix has been released as 0.56.1

@home-assistant home-assistant locked and limited conversation to collaborators Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core Hacktoberfest
Projects
None yet
Milestone
0.56.1
Development

Successfully merging this pull request may close these issues.
7 participants
@pvizeli @vittoriom @bachya @balloob @fabaff @balloobbot @homeassistant
0