-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Add fan and reduce I/O calls in radiotherm #10437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6e63db2
Added fan support. Reduced number of calls to the thermostat to a mi…
TD22057 8a5dc84
Move temp rounding to config schema
TD22057 b2ce9ec
Fixed pep8 errors
TD22057 ed1662d
Fix for review comments.
TD22057 33136e6
removed unneeded if block
TD22057 63cf64d
Added missing precision attr back
TD22057 de626ee
Fixed pylint errors
TD22057 59c79bc
Code review fixes. Fan support by model number.
TD22057 5018641
Defined circulate state
TD22057 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only assigned not used.
8000There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added because I want to support a binary sensor in the future to measure when the fan is actually on and off. I'm not sure how to do that yet but having the fan state saved is part of it so I added it when updating all the other state variables.