8000 Bump pyvesync for vesync by cdnninja · Pull Request #138681 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ core Public

Bump pyvesync for vesync #138681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

Bump pyvesync for vesync #138681

merged 3 commits into from
Feb 17, 2025

Conversation

cdnninja
Copy link
Contributor
@cdnninja cdnninja commented Feb 16, 2025 •
edited
Loading

Proposed change

Bump pyvesync to latest. diff: webdjoe/pyvesync@2.1.17...2.1.18

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdnninja cdnninja changed the title Bump pyvesync Bump pyvesync for vesync Feb 16, 2025
@cdnninja cdnninja mentioned this pull request Feb 16, 2025
Merged
andrewsayre
andrewsayre requested changes Feb 17, 2025
View reviewed changes
Copy link
Member
@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you need to update the diagnostics snapshots (or something broke).

Thanks for taking a look,
Andy

@home-assistant home-assistant bot marked this pull request as draft February 17, 2025 01:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdnninja
Copy link
Contributor Author

Strange - local tests were passing. I will correct and resubmit.

@cdnninja cdnninja mentioned this pull request Feb 17, 2025
Merged
21 tasks
CloCkWeRX
CloCkWeRX approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor
@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cdnninja cdnninja marked this pull request as ready for review February 17, 2025 03:02
@home-assistant home-assistant bot requested a review from andrewsayre February 17, 2025 03:02
andrewsayre
andrewsayre approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrewsayre andrewsayre added this to the 2025.2.5 milestone Feb 17, 2025
@andrewsayre andrewsayre merged commit 6b90e7b into home-assistant:dev Feb 17, 2025
46 checks passed
@cdnninja cdnninja deleted the pyvesyncBump branch February 17, 2025 03:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CloCkWeRX CloCkWeRX CloCkWeRX approved these changes

@andrewsayre andrewsayre andrewsayre approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency integration: vesync Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@cdnninja @CloCkWeRX @andrewsayre @frenck
0