8000 Bump aiocomelit to 0.12.0 to use async_create_clientsession in Comelit integration by chemelli74 · Pull Request #143528 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Bump aiocomelit to 0.12.0 to use async_create_clientsession in Comelit integration #143528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

Bump aiocomelit to 0.12.0 to use async_create_clientsession in Comelit integration #143528

merged 2 commits into from
Apr 24, 2025

Conversation

chemelli74
Copy link
Contributor
@chemelli74 chemelli74 commented Apr 23, 2025 •
edited
Loading

Proposed change

HomeAssistant will create the aiohttp ClientSession instead of creating it inside the library

Needs aiocomelit v0.12.0 because of a breaking change

changelog: https://github.com/chemelli74/aiocomelit/releases/tag/v0.12.0
diff: chemelli74/aiocomelit@v0.11.3...v0.12.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

bdraco
bdraco reviewed Apr 24, 2025
View reviewed changes
@chemelli74 chemelli74 marked this pull request as ready for review April 24, 2025 07:11
@chemelli74 chemelli74 changed the title Use async_create_clientsession in Comelit integration Bump aiocomelit to 0.12.0 to use async_create_clientsession in Comelit integration Apr 24, 2025
@chemelli74
Copy link
Contributor Author

Thx!

@chemelli74 chemelli74 merged commit 55de915 into home-assistant:dev Apr 24, 2025
48 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-aiohttp-session branch April 24, 2025 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality integration: comelit Quality Scale: bronze quality-scale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chemelli74 @bdraco
0