8000 Add subentry reconfigure flow to ntfy integration by tr4nt0r · Pull Request #143718 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add subentry reconfigure flow to ntfy integration #143718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add subentry reconfigure flow to ntfy integration #143718

wants to merge 3 commits into from

Conversation

tr4nt0r
Copy link
Contributor
@tr4nt0r tr4nt0r commented Apr 26, 2025 •
edited
Loading

Proposed change

Currently only allows for reconfiguring the display name (subentry title), but PR #143529 will introduce more configuation options

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r force-pushed the ntfy_subentry_reconfigure branch from 0f74e7a to a0c6e4d Compare April 26, 2025 20:54
@tr4nt0r tr4nt0r mentioned this pull request Apr 30, 2025
Closed
19 tasks
@tr4nt0r tr4nt0r force-pushed the ntfy_subentry_reconfigure branch from a0c6e4d to 0573d4b Compare April 30, 2025 13:05
joostlek
joostlek requested changes Apr 30, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft April 30, 2025 17:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tr4nt0r tr4nt0r marked this pull request as ready for review April 30, 2025 17:45
@home-assistant home-assistant bot requested a review from joostlek April 30, 2025 17:45
hanwg
hanwg approved these changes May 11, 2025
View reviewed changes
Copy link
Contributor
@hanwg hanwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works fine

@tr4nt0r tr4nt0r force-pushed the ntfy_subentry_reconfigure branch from 0573d4b to 20aaf28 Compare June 20, 2025 22:28
@tr4nt0r tr4nt0r force-pushed the ntfy_subentry_reconfigure branch from 20aaf28 to ab8bec6 Compare July 3, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanwg hanwg hanwg approved these changes

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: ntfy new-feature Quality Scale: bronze
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tr4nt0r @hanwg @joostlek
0