8000 Repair Z-Wave unknown controller by MartinHjelmare · Pull Request #144738 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Repair Z-Wave unknown controller #144738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

Repair Z-Wave unknown controller #144738

merged 3 commits into from
May 12, 2025

Conversation

MartinHjelmare
Copy link
Member
@MartinHjelmare MartinHjelmare commented May 12, 2025 •
edited
Loading

Breaking change

Proposed change

  • Add a repair flow to migrate the config entry unique id if an unknown controller is connected. An unknown controller can happen if the controller was reset outside of Home Assistant, or the NVM was restored outside of Home Assistant, or it's a different controller. If it's a different controller we ask the user to create a new config entry instead. If the user confirms it's the same controller they can finish the flow to migrate the unique id and fix the issue.

repair_unknown_controller

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare requested a review from a team as a code owner May 12, 2025 12:51
@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare added this to the 2025.5.2 milestone May 12, 2025
MartinHjelmare
MartinHjelmare commented May 12, 2025
View reviewed changes
frenck
frenck reviewed May 12, 2025
View reviewed changes
@MartinHjelmare @frenck
Improve English
c9027a9 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@frenck frenck merged commit 3eed552 into dev May 12, 2025
34 checks passed
@frenck frenck deleted the fix-zwave-config-entry-unknown-controller branch May 12, 2025 19:18
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: zwave_js Quality Scale: No score
Projects
None yet
Milestone
2025.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinHjelmare @frenck
0