8000 Fix mqtt subentry device name is not required but should be by jbouwh · Pull Request #144289 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix mqtt subentry device name is not required but should be #144289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Fix mqtt subentry device name is not required but should be #144289

merged 1 commit into from
May 6, 2025

Conversation

jbouwh
Copy link
Contributor
@jbouwh jbouwh commented May 5, 2025

Proposed change

A mqtt subentry device name is not required. The current schema does not validate on this, but not supplying a name will throw an error.
This PR marks the device name field as required.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

8000
@jbouwh jbouwh requested review from emontnemery and bdraco as code owners May 5, 2025 21:08
@jbouwh jbouwh added this to the 2025.5.0 milestone May 5, 2025
@home-assistant
Copy link
home-assistant bot commented May 5, 2025

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh changed the title Fix mqtt subentry device name is not required Fix mqtt subentry device name is not required but should be May 5, 2025
tyriis
tyriis approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@tyriis tyriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me

@balloob balloob merged commit 12f9a11 into dev May 6, 2025
48 checks passed
@balloob balloob deleted the mqtt-subentry-device_name-required branch May 6, 2025 02:39
balloob pushed a commit that referenced this pull request May 6, 2025
@jbouwh @balloob
Fix mqtt subentry device name is not required but should be (#144289)
7f7a33b 
Fix mqtt subentry device name is not required
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@tyriis tyriis tyriis approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@emontnemery emontnemery

Labels
bugfix by-code-owner cherry-picked cla-signed core integration: mqtt Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbouwh @balloob @tyriis @bdraco @emontnemery
0