8000 Doorbell Event is fired just once in homematicip_cloud by hahn-th · Pull Request #144357 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Doorbell Event is fired just once in homematicip_cloud #144357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

Doorbell Event is fired just once in homematicip_cloud #144357

merged 6 commits into from
May 14, 2025

Conversation

hahn-th
Copy link
Contributor
@hahn-th hahn-th commented May 6, 2025

Proposed change

The doorbell fires two different events when the doorbell button is pressed. Added a filter to fire just the correct event.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

joostlek
joostlek requested changes May 9, 2025
View reviewed changes
@home-assistant
Copy link
home-assistant bot commented May 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 9, 2025 11:21
@hahn-th hahn-th marked this pull request as ready for review May 9, 2025 21:14
@home-assistant home-assistant bot requested a review from joostlek May 9, 2025 21:14
@joostlek joostlek merged commit 063deab 8000 into home-assistant:dev May 14, 2025
34 checks passed
@joostlek joostlek added this to the 2025.5.2 milestone May 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
@hahn-th hahn-th deleted the fix-event branch May 15, 2025 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: homematicip_cloud Quality Scale: No score
Projects
None yet
Milestone
2025.5.2
Development

Successfully merging this pull request may close these issues.

HmIP-DSD-PCB sensor generating double events
3 participants
@hahn-th @joostlek @frenck
0