8000 Only set suggested area for new SmartThings devices by joostlek · Pull Request #145063 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Only set suggested area for new SmartThings devices #145063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Only set suggested area for new SmartThings devices #145063

merged 1 commit into from
May 16, 2025

Conversation

joostlek
Copy link
Member

Proposed change

Only set suggested area for new SmartThings devices

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.5.2 milestone May 16, 2025
chemelli74
chemelli74 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostlek joostlek merged commit e800695 into home-assistant:dev May 16, 2025
34 checks passed
@joostlek joostlek deleted the st-sug-area branch May 16, 2025 17:53
frenck pushed a commit that referenced this pull request May 16, 2025
@joostlek @frenck
Only set suggested area for new SmartThings devices (#145063)
4906e78
@frenck frenck mentioned this pull request May 16, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chemelli74 chemelli74 chemelli74 approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: smartthings Quality Scale: bronze small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.5.2
Development

Successfully merging this pull request may close these issues.

SmartThings device room/location keeps resetting after Home Assistant restart
3 participants
@joostlek @chemelli74 @frenck
0