8000 Add Seko PoolDose integration by lmaertin · Pull Request #146972 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Seko PoolDose integration #146972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: dev
Choose a base branch
from
Draft

Add Seko PoolDose integration #146972

wants to merge 27 commits into from

Conversation

lmaertin
Copy link
@lmaertin lmaertin commented Jun 16, 2025 •
edited
Loading

Proposed change

Add a new integration for local polling of SEKO PoolDose devices. This integration enables cloudless monitoring and control of a PoolDose Dual/Double device for automatic dosing of Pools or Spas.

Tested intensively with a PoolDose Dual/Double WiFi. Documentation and Brands also planned in PRs on the dedicated respos.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

lmaertin added 18 commits June 3, 2025 20:32
@lmaertin
initial functionality: orp,ph,temp + dose on/off + tests
50be05b
@lmaertin
moved constants to const file
029ffda
@lmaertin
minor
448bdce
@lmaertin
bound entities to a device, Added initial device data information
d02e573
@lmaertin
Merge branch 'home-assistant:dev' into seko-pooldose-component
6af5d78
@lmaertin
fixed device info
5450236
@lmaertin
cleanup and activate binary sensors, numbers and switches again
435bc95
@lmaertin
Added frequency switch and configuration to hide optional entities by…
d8b1101 
… default
@lmaertin
Added remaining sensors, binary_sensors and select entities. Improved…
8fcf249 
… translation.
@lmaertin
Merge branch 'home-assistant:dev' into seko-pooldose-component
ab5b136
@lmaertin
added modelid
4a115ed
@lmaertin
derive model and model_id from device debug infos
38978dc
@lmaertin
added reconfiguration feature for scan_interval and timeout
000a38a
@lmaertin
clean-up
2835dce
@lmaertin
Added Testcases, fixed from quality scale requirements, improved robu…
aa99e82 
…stness of MAC Address http request
@lmaertin
Full test coverage of config_flow
996e1cb
@lmaertin
fixes further quality scale needs, improved test coverage
9eabab1
@lmaertin
changed default hostname + uppercase of SEKO
9da43f6
home-assistant[bot]
home-assistant bot previously requested changes Jun 16, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lmaertin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft June 16, 2025 18:50
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant[bot]
home-assistant bot previously requested changes Jun 16, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

This was referenced Jun 16, 2025
Draft
Open
@lmaertin lmaertin marked this pull request as ready for review June 16, 2025 19:35
@home-assistant home-assistant bot dismissed stale reviews from themself June 16, 2025 19:35

Stale

joostlek
joostlek requested changes Jun 17, 2025
View reviewed changes
Copy link
Member
@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device specific code should exist in a separate dependency hosted on pypi

@home-assistant home-assistant bot marked this pull request as draft June 17, 2025 09:22
@lmaertin
Copy link
Author

The device specific code should exist in a separate dependency hosted on pypi

@joostlek Thanks for your feedback. I will consider a re-write of the API-specific code as python module.

@lmaertin
Copy link
Author
lmaertin commented Jul 2, 2025

Alpha version of pypi package is done. Needs some more testing. Afterwards PR will be updated. It's not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek requested changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed has-tests integration: pooldose new-integration quality-scale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmaertin @joostlek
0