Fix derivative migration from 'none' unit_prefix #147820
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @afaucogney, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
19 tasks
elupus
requested changes
Jul 7, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
elupus
reviewed
Jul 8, 2025
| ) | ||
| async def test_options( | ||
| hass: HomeAssistant, platform, initial_unit_prefix, minor_version | ||
| ) -> None: |
There was a problem hiding this comment.
I think you should have just added a migration test in test_init.py instead of this to be honest.
There was a problem hiding this comment.
Yeah I like that better too, moved 👍
elupus
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In #101312, the option "none" was removed from derivative unit_prefix.
A migration was added to the sensor creation to treat "none" as
None, but this wasn't completely handled in the options flow.Legacy sensors with their option still set to
"none"still cause a problem when showing the options form, as frontend would try to resubmit"none"as an option when changing a different field, causing a cryptic error.This change completes the missing migration step by deleting the
"none"key when presenting the options form, so that the key is removed from config_entry when the options form is resubmitted.Also adds coverage that was previously missing covering the migration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: