8000 Allow use of Selector in ObjectSelector fields by gjohansson-ST · Pull Request #147929 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow use of Selector in ObjectSelector fields #147929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Allow use of Selector in ObjectSelector fields #147929

wants to merge 2 commits into from

Conversation

gjohansson-ST
Copy link
Member
@gjohansson-ST gjohansson-ST commented Jul 2, 2025 •
edited
Loading

Proposed change

Extend the fields in ObjectSelector to also allow to use a Selector instead of only using a dict.
This simplifies the use of this selector for use in config flows

Ref: #147215

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Jul 2, 2025
@gjohansson-ST gjohansson-ST mentioned this pull request Jul 2, 2025
Draft
19 tasks
gjohansson-ST
gjohansson-ST commented Jul 2, 2025
View reviewed changes
homeassistant/helpers/selector.py
@@ -1142,7 +1143,7 @@ class ObjectSelectorConfig(BaseSelectorConfig):
fields: dict[str, ObjectSelectorField]
multiple: bool
label_field: str
description_field: bool
description_field: str
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix (typing)

@gjohansson-ST gjohansson-ST marked this pull request as ready for review July 2, 2025 07:56
@gjohansson-ST gjohansson-ST requested a review from a team as a code owner July 2, 2025 07:56
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed core new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjohansson-ST @frenck
0