Add reconfigure flow to eheimdigital #147930
Open
+147
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for reconfiguring an existing Eheim Digital integration without removing the entry.
- Implements
async_step_reconfigureinconfig_flow.pyto handle updating host and unique ID. - Updates
strings.jsonandquality_scale.yamlto include reconfigure-specific messages and mark the rule as done. - Adds tests for successful reconfigure, connection failures, and unique ID mismatches in
test_config_flow.py.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config_flow.py | Added async_step_reconfigure implementation |
| strings.json | Added translation keys for reconfigure flow and abort reasons |
| quality_scale.yaml | Marked reconfiguration-flow rule as done |
| tests/components/eheimdigital/test_config_flow.py | Added unit tests covering reconfigure scenarios |
Comments suppressed due to low confidence (2)
homeassistant/components/eheimdigital/strings.json:28
- [nitpick] Consider using a translation key or aligning this message with other common config flow abort messages to maintain consistency and support localization.
"unique_id_mismatch": "The identifier does not match the previous identifier"
tests/components/eheimdigital/test_config_flow.py:260
- It may be useful to also assert that the config entry's data (e.g.,
host) was correctly updated after a successful reconfigure to fully verify the data migration.
assert result["reason"] == "reconfigure_successful"
Comment on lines
+169
to
+171
| except Exception: # noqa: BLE001 | ||
| errors["base"] = "unknown" | ||
| LOGGER.exception("Unknown exception occurred") |
There was a problem hiding this comment.
Catching a broad Exception can mask unexpected errors; consider narrowing this to specific exception types or re-raising unexpected ones to avoid hiding critical failures.
Suggested change
| except Exception: # noqa: BLE001 | |
| errors["base"] = "unknown" | |
| LOGGER.exception("Unknown exception occurred") | |
| except Exception as err: # noqa: BLE001 | |
| LOGGER.exception("Unexpected exception occurred: %s", err) | |
| raise |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the reconfigure flow to eheimdigital.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: