8000 Override connect method in RecorderPool by emontnemery · Pull Request #148490 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ core Public
< 8000 /div>

Override connect method in RecorderPool #148490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Override connect method in RecorderPool #148490

wants to merge 1 commit into from

Conversation

emontnemery
Copy link
Contributor

Proposed change

Override connect method in RecorderPool; we need to call the connect method from the correct base class depending on from which thread we're called.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 13:19
@emontnemery emontnemery requested a review from a team as a code owner July 9, 2025 13:19
@home-assistant
Copy link
home-assistant bot commented Jul 9, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot
Copilot AI reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR customizes the pool’s connect method in RecorderPool so it dispatches to the appropriate base class depending on the calling thread.

  • Adds PoolProxiedConnection import for proper return typing.
  • Introduces a connect override that checks the current thread against recorder_and_worker_thread_ids.
  • Uses super().connect() for recorder threads and NullPool.connect() otherwise.
Comments suppressed due to low confidence (1)

homeassistant/components/recorder/pool.py:123

  • Add unit tests for this connect override to verify both branches: when the thread ID is in recorder_and_worker_thread_ids and when it is not, ensuring the correct underlying pool method is called.
    def connect(self) -> PoolProxiedConnection:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed core integration: recorder Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

35BE
1 participant
@emontnemery
0