Remove history first refresh from Teslemetry #148531
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjohansson-ST
requested changes
Jul 10, 2025
| @@ -55,7 +55,7 @@ | |||
| 'last_changed': <ANY>, | |||
| 'last_reported': <ANY>, | |||
| 'last_updated': <ANY>, | |||
| 'state': '0.684', | |||
| 'state': 'unknown', | |||
There was a problem hiding this comment.
It's a bit semantics but should these be unavailable and not unknown at first?
Besides that maybe do a refresh before the snapshot to get proper values here in the snapshot file.
| @@ -117,7 +119,7 @@ async def test_energy_history_no_time_series( | |||
|
|
|||
| entity_id = "sensor.energy_site_battery_discharged" | |||
| state = hass.states.get(entity_id) | |||
| assert state.state == "0.036" | |||
| assert state.state == STATE_UNKNOWN | |||
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Pulling energy history data on startup can be slow, and even worse sometimes fails which causes the entire integration to fail startup. Doing a refresh on startup isn't necessary so this PR removes it.
This is a bugfix for a small subset of users who have energy sites without history data. Suitable for patch release.
Tests from init were removed as the refresh no longer occurs at init.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: