8000 Add test fixture for Tuya cover by FredrikM97 · Pull Request #148660 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add test fixture for Tuya cover #148660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Add test fixture for Tuya cover #148660

wants to merge 2 commits into from
+149 −0

Conversation

FredrikM97
Copy link
Contributor

Proposed change

Add fixture for Tuya platform cover.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@FredrikM97
Copy link
Contributor Author

@epenet What do you think? Only issue I have is that I could not find the real id from #71242.

@epenet
Copy link
Contributor
epenet commented Jul 12, 2025

Please fix conflicts

@epenet epenet marked this pull request as draft July 12, 2025 21:19
@FredrikM97 FredrikM97 force-pushed the feat/add_fixture_for_tuya_cover branch from ea8f243 to 41a9989 Compare July 12, 2025 23:05
@FredrikM97
Copy link
Contributor Author

@epenet Now the conflicts is fixed. I also added a test to verify the position of current_position so tests will break if modified moving foward.

@epenet epenet changed the title feat: Add fixture for Tuya cover Add test fixture for Tuya cover Jul 13, 2025
epenet
epenet reviewed Jul 13, 2025
View reviewed changes
tests/components/tuya/__init__.py
@@ -97,6 +97,10 @@
# https://github.com/home-assistant/core/issues/138372
Platform.SENSOR,
],
"am43_corded_motor_zigbee_cover": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this dict sorted and move it up

epenet
epenet reviewed Jul 13, 2025
View reviewed changes
tests/components/tuya/__init__.py
@@ -97,6 +97,10 @@
# https://github.com/home-assistant/core/issues/138372
Platform.SENSOR,
],
"am43_corded_motor_zigbee_cover": [
# https://github.com/home-assistant/core/issues/71242
Platform.COVER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add select platform here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epenet epenet epenet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed code-quality has-tests integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredrikM97 @epenet
0