Move medcom_ble coordinator to separate module #148009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @elafargue, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
Moves the Medcom BLE update coordination logic into a dedicated module to prepare for runtime_data usage.
- Introduce
MedcomBleUpdateCoordinatorin a newcoordinator.py - Refactor
async_setup_entryin__init__.pyto use the new coordinator - Remove inline update logic in favor of the centralized coordinator
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/medcom_ble/coordinator.py | Added new MedcomBleUpdateCoordinator class to handle data updates |
| homeassistant/components/medcom_ble/init.py | Refactored to use the new coordinator and removed inline update logic |
Comments suppressed due to low confidence (3)
homeassistant/components/medcom_ble/coordinator.py:1
- [nitpick] The module-level docstring is quite generic. Consider clarifying that this module provides the
MedcomBleUpdateCoordinatorfor fetching BLE device data.
"""The Medcom BLE integration."""
homeassistant/components/medcom_ble/coordinator.py:1
- This new coordinator module doesn’t have corresponding unit tests. Please add tests covering successful data fetches and error handling (e.g.,
BleakErrorscenarios).
"""The Medcom BLE integration."""
homeassistant/components/medcom_ble/coordinator.py:43
- [nitpick] Instantiating
MedcomBleDeviceDataon every update may be unnecessary if it's stateless. Consider creating it once in__init__and reusing it to reduce allocations and centralize setup.
inspector = MedcomBleDeviceData(_LOGGER, self._elevation, self._is_metric)
frenck
requested changes
Jul 3, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA, preliminary for runtime_data
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: