Use HassKey in media_source #148011
Merged
Use HassKey in media_source #148011
+23
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the old raw DOMAIN key in hass.data with a typed HassKey (MEDIA_SOURCE_DATA) for storing media sources, improving type safety and clarity.
- Define and export
MEDIA_SOURCE_DATA: HassKey[...]inconst.py - Replace all
hass.data[DOMAIN]usages withhass.data[MEDIA_SOURCE_DATA] - Update imports and initialization in
mo 8000 dels.py,local_source.py, and__init__.py
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/media_source/const.py | Introduce MEDIA_SOURCE_DATA: HassKey[...] and export it |
| homeassistant/components/media_source/init.py | Initialize and use hass.data[MEDIA_SOURCE_DATA] for storage |
| homeassistant/components/media_source/models.py | Update imports and replace DOMAIN lookups with MEDIA_SOURCE_DATA |
| homeassistant/components/media_source/local_source.py | Register and retrieve local source via MEDIA_SOURCE_DATA |
Comments suppressed due to low confidence (2)
homeassistant/components/media_source/const.py:15
- Add tests to verify that media sources are correctly stored and retrieved via the new
MEDIA_SOURCE_DATAkey inhass.data, ensuring the migration from the oldDOMAINkey behaves as expected.
MEDIA_SOURCE_DATA: HassKey[dict[str, MediaSource]] = HassKey(DOMAIN)
homeassistant/components/media_source/init.py:82
- Add a unit test to confirm that
hass.datais initialized with theMEDIA_SOURCE_DATAkey and that platform registration populates it correctly.
hass.data[MEDIA_SOURCE_DATA] = {}
zweckj
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: