Use runtime_data in melcloud #148012
Merged
Use runtime_data in melcloud #148012
+18
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MelCloud integration to use the new entry.runtime_data API instead of storing devices in hass.data. It introduces a typed alias for the config entry, updates all platforms to pull from runtime_data, and cleans up the unload logic.
- Define
MelCloudConfigEntryalias and assign fetched devices toentry.runtime_data - Update
async_setup_entryin climate, sensor, water_heater, and diagnostics to useruntime_data - Simplify
async_unload_entryby removing manualhass.datacleanup
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
__init__.py |
Add MelCloudConfigEntry alias; set and stop using hass.data; simplify unload |
climate.py |
Update imports and async_setup_entry to use entry.runtime_data |
sensor.py |
Remove DOMAIN usage; update imports and setup to use runtime_data |
water_heater.py |
Update imports and async_setup_entry to consume entry.runtime_data |
diagnostics.py |
Switch diagnostics helper to accept MelCloudConfigEntry and drop ConfigEntry import |
Comments suppressed due to low confidence (2)
homeassistant/components/melcloud/water_heater.py:33
- The docstring mentions climate setup in the water_heater module. Update it to reflect water heater entity setup for clarity.
"""Set up MelCloud device climate based on config_entry."""
homeassistant/components/melcloud/water_heater.py:34
- Consider adding a test for
async_setup_entryto verify thatentry.runtime_datais correctly populated and consumed by the water heater platform.
mel_devices = entry.runtime_data
frenck
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: