Use entry.async_on_unload in monoprice #148016
Merged
+2
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @etsinko, @OnFreund, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Monoprice integration’s lifecycle handling by using entry.async_on_unload for cleanup and removes the now-unused UNDO_UPDATE_LISTENER constant.
- Removed the
UNDO_UPDATE_LISTENERconstant fromconst.py - Switched from manual listener unsubscribe to
entry.async_on_unloadinasync_setup_entry - Eliminated manual unsubscribe call and storage of the listener in
async_unload_entry
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| const.py | Dropped unused UNDO_UPDATE_LISTENER constant |
| init.py | Replaced manual listener cleanup with async_on_unload call and removed corresponding data storage |
Comments suppressed due to low confidence (1)
homeassistant/components/monoprice/init.py:38
- Consider adding a test to verify that the update listener is unsubscribed automatically via
async_on_unloadwhen the config entry is unloaded.
entry.async_on_unload(entry.add_update_listener(_update_listener))
frenck
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA, preliminary for runtime_data
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: