8000 Add data_description to forms in Android TV Remote by tronikos · Pull Request #148045 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add data_description to forms in Android TV Remote #148045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tronikos
Copy link
Member
@tronikos tronikos commented Jul 3, 2025

Breaking change

Proposed change

Add data_description to forms in Android TV Remote

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
home-assistant bot commented Jul 3, 2025

Hey there @Drafteed, mind taking a look at this pull request as it has been labeled with an integration (androidtv_remote) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv_remote can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv_remote Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck requested a review from Copilot July 3, 2025 17:59
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhance form field guidance by adding data_description entries to the Android TV Remote integration’s config flow strings.

  • Introduce data_description for host and PIN prompts
  • Split summary and detailed descriptions for apps and enable_ime in the initialization form
  • Add descriptive entries for app configuration fields (app_name, app_icon, app_delete)
Comments suppressed due to low confidence (2)

homeassistant/components/androidtv_remote/strings.json:10

  • The new data_description keys should be added to translation files for other locales to ensure proper internationalization support.
        "data_description": {

homeassistant/components/androidtv_remote/strings.json:11

  • Add or update tests to verify that the new data_description entries are correctly exposed in the Android TV Remote config flow.
          "host": "The hostname or IP address of the Android TV device."

Co-authored-by: Artem Draft <Drafteed@users.noreply.github.com>
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tronikos 👍

../Frenck

@frenck frenck merged commit 5f9cc0a into home-assistant:dev Jul 3, 2025
34 checks passed
@tronikos tronikos deleted the androidtv_remote_data_description branch July 4, 2025 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0