-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Add data_description to forms in Android TV Remote #148045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data_description to forms in Android TV Remote #148045
Conversation
Hey there @Drafteed, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enhance form field guidance by adding data_description
entries to the Android TV Remote integration’s config flow strings.
- Introduce
data_description
for host and PIN prompts - Split summary and detailed descriptions for
apps
andenable_ime
in the initialization form - Add descriptive entries for app configuration fields (
app_name
,app_icon
,app_delete
)
Comments suppressed due to low confidence (2)
homeassistant/components/androidtv_remote/strings.json:10
- The new
data_description
keys should be added to translation files for other locales to ensure proper internationalization support.
"data_description": {
homeassistant/components/androidtv_remote/strings.json:11
- Add or update tests to verify that the new
data_description
entries are correctly exposed in the Android TV Remote config flow.
"host": "The hostname or IP address of the Android TV device."
Co-authored-by: Artem Draft <Drafteed@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tronikos 👍
../Frenck
Breaking change
Proposed change
Add data_description to forms in Android TV Remote
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: