Fix adding a work area in Husqvarna Automower #148358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
I fixed mypy. Before I do tests, can I have a feedback, if it's okay to implement in here, or if I should do it in the library? |
joostlek
reviewed
Jul 7, 2025
|
I think the update code looks good now but its indeed strange that we have to write to self.data, I think we can fix that, but as you said there probably is an issue with it so we need to dive in a litle bit |
Thomas55555
commented
Jul 9, 2025
gjohansson-ST
approved these changes
Jul 9, 2025
|
Can this get merged, or do we need to wait for a approval from Joost? |
joostlek
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Poll all data, when a new work area is announced with an calendar event.
As an alternative I could add this in the library.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: