Expose Wemo component availability to home assistant #14995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok to merge when travis build issues addressed. |
|
This should pass now. I thought the dimmer worked the same as the lights but the dimmer works like the bridge itself. It will not show up at all if it is not powered, making the change for the dimmer redundant so I have removed it. |
|
Please fix the lint issue: |
Revert "Do not add availability feature to dimmer - it works differently" This reverts commit f64e717.
|
Coverage issues aren't related to this PR; merging and closing. |
eavanvalkenburg
pushed a commit
to eavanvalkenburg/home-assistant
that referenced
this pull request
Jun 28, 2018
…14995) * Expose Wemo component availability to home assistant * Do not add availability feature to dimmer - it works differently * Brain fade, deleted completely the wrong thing. Revert "Do not add availability feature to dimmer - it works differently" This reverts commit f64e717. * (2nd attempt) Do not add availability feature to dimmer - it works differently
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…14995) * Expose Wemo component availability to home assistant * Do not add availability feature to dimmer - it works differently * Brain fade, deleted completely the wrong thing. Revert "Do not add availability feature to dimmer - it works differently" This reverts commit f64e717. * (2nd attempt) Do not add availability feature to dimmer - it works differently
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to expose the Wemo availability (i.e. does it have external power or connectivity) in home assistant.
This feature works a bit better with the following update to pywemo, although it is not required. Prior to the pull request below, pywemo had a tendency to report non-connectable devices as a 'available' in some cases.
pywemo/pywemo#100