Fix #14919. Should throw exception when camera stream closed by frontend #15028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…losed by frontend
|
I'm not sure if that is the correct fix. It's also not python like to catch a exception for reraise it later, please fix that. I'll check that local. Thanks for discover a solution. |
|
I just keep that logging statement to keep backward compatibility. If you don't like reraise, we can simply not catch asyncio.CancelledError, the caller will quietly handle that exception. |
|
@pvizeli any update? More people reported that issue. |
|
Please cleanup the exception handling to pythonic -> http://www.ianbicking.org/blog/2007/09/re-raising-exceptions.html We have time until end of this week before next beta comes. |
balloob
approved these changes
Jun 25, 2018
pvizeli
added a commit
that referenced
this pull request
Jun 25, 2018
pvizeli
added a commit
that referenced
this pull request
Jun 25, 2018
* Revert "Fix #14919. Should throw exception when camera stream closed by frontend (#15028)" This reverts commit 508d045. * Revert "Fix pylintrc section order and option placements (#15120)" This reverts commit dbae410. * Revert "Add storage helper and migrate config entries (#15045)" This reverts commit ae51dc0. * Revert "Add language to dark sky weather component (#15130)" This reverts commit 672a3c7.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When user closed camera stream window, we should simply abort the stream by thrown exception. The issue has been masked before aiohttp 3.3.0. However after 3.3.0, if you try to operate on closed connection, a ConnectionResetError will be thrown instead of asyncio.CancelledError. ConnectionResetError will eventually throw to top level, since nobody handle it (should not be handled)
Change to re-throw asyncio.CancelledError fix the issue.
Related issue (if applicable): fixes #14919
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass