8000 Add precipitations to Openweathermap daily forecast mode by Yevgenium · Pull Request #15240 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add precipitations to Openwe 8000 athermap daily forecast mode #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2018
Merged

Add precipitations to Openweathermap daily forecast mode #15240

merged 2 commits into from
Jul 1, 2018

Conversation

Yevgenium
Copy link
Contributor
@Yevgenium Yevgenium commented Jul 1, 2018 •
edited
Loading

Description:

Add precipitations to Openweathermap daily forecast mode

Example entry for configuration.yaml (if applicable):

weather:
  - platform: openweathermap
    api_key: YOUR_API_KEY
    mode: daily

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jul 1, 2018
@ghost ghost assigned fabaff Jul 1, 2018
fabaff
fabaff approved these changes Jul 1, 2018
View reviewed changes
Copy link
Member
@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@Yevgenium
Copy link
Contributor Author

Thank you

@fabaff fabaff merged commit c0229eb into home-assistant:dev Jul 1, 2018
@ghost ghost removed the in progress label Jul 1, 2018
@Yevgenium Yevgenium deleted the patch-1 branch July 1, 2018 14:46
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@Yevgenium @awarecan
Add precipitations to Openweathermap daily forecast mode (home-assist…
d70acb0 
…ant#15240)

* Add precipitations to daily forecast mode

* Remove line breaks
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@fabaff fabaff

Labels
cla-signed integration: openweathermap small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yevgenium @fabaff @homeassistant
0