8000 Expose thermostat into light platform by rweglarz · Pull Request #18138 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expose thermostat into light platform #18138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expose thermostat into light platform #18138

wants to merge 1 commit into from

Conversation

rweglarz
Copy link
@rweglarz rweglarz commented Nov 3, 2018

Description:

Related issue (if applicable): fixes #14526

@rweglarz rweglarz requested a review from a team as a code owner November 3, 2018 09:41
@homeassistant
Copy link
Contributor

Hi @rweglarz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Nov 3, 2018
@balloob
Copy link
Member
balloob commented Nov 3, 2018

This makes absolute no sense. Don't put thermostats as lights.

@balloob balloob closed this Nov 3, 2018
@ghost ghost removed the in progress label Nov 3, 2018
@rweglarz
Copy link
Author
rweglarz commented Nov 3, 2018

This makes absolute no sense. Don't put thermostats as lights.

Hi Paulus,
could you please provide some guidance what would be the proper way to fix issue #14526?

thanks
Rafal

@Sevift
Copy link
Sevift commented Nov 12, 2018

@rweglarz, your fix
Expose thermostat into light platform is working!
Developers, include it faster ))

@Sevift Sevift mentioned this pull request Oct 12, 2019
Closed
@DamianFlynn
Copy link

Why a light. That only adds to the confusion. A simple generic sensor works just as well

@jmarsik
Copy link
jmarsik commented Dec 28, 2019

@DamianFlynn It's a light (or cover in newer version of @rweglarz code) because they also want to control the value, not only read it. In manufacturer specific mode/preset of the TRV this value can be used to directly control valve opening percentage.

I don't see any suitable entity type in Home Assistant for this right now. For example in Google Assistant Smart Home reference docs it's Valve device type with OpenClose trait (that also allows setting of exact position). See https://developers.google.com/assistant/smarthome/guides/valve.html.

@apolopeix apolopeix mentioned this pull request Oct 23, 2020
Closed
@kpine kpine mentioned this pull request Feb 22, 2021
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed integration: zwave small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Z-Wave State for 'SwitchMultiLevel' is Ignored
6 participants
@rweglarz @homeassistant @balloob @Sevift @DamianFlynn @jmarsik
0