8000 Fix for blink initialization failure. Fixes #20335 by fronzbot · Pull Request #20351 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix for blink initialization failure. Fixes #20335 8000 #20351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Fix for blink initialization failure. Fixes #20335 #20351

merged 1 commit into from
Jan 23, 2019

Conversation

fronzbot
Copy link
Contributor
@fronzbot fronzbot commented Jan 23, 2019

Description:

Due to upstream API endpoint changes for Blink, the current integration fails to load. I have a fix in the blinkpy library to handle this error until a long term fix is in (ie. finding the new endpoint). This fix allows for everything in the Blink home-assistant component to continue working except for motion detection.

Breaking Change:
Blink motion detection temporarily broken due to API change.

blinkpy change log: https://github.com/fronzbot/blinkpy/releases/tag/v0.11.2

Related issue (if applicable): fixes #20335

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@dgomes

@ghost ghost added the in progress label Jan 23, 2019
@fronzbot
Copy link
Contributor Author

So the cov test failed and I'm not sure why. The failure is unrelated to any commits I made, as far as I can tell. Any ideas?

@dgomes
Copy link
Contributor
dgomes commented Jan 23, 2019

@balloob currently blink is broken for all previous versions, any chance of cutting this into 0.86 ?

@Danielhiversen Danielhiversen added this to the 0.86.0 milestone Jan 23, 2019
@Danielhiversen
Copy link
Member

Please add a link to the change log of the library to the pr description

@Danielhiversen Danielhiversen merged commit 7ca7951 into home-assistant:dev Jan 23, 2019
@ghost ghost removed the in progress label Jan 23, 2019
@fronzbot fronzbot deleted the blink-hotfix branch January 23, 2019 19:51
@fronzbot
Copy link
Contributor Author

@balloob seems like this just missed the window for 0.86. Currently the Blink platform does not work without this change, any chance for a 0.86.1 bugfix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer able to set up the blink camera component
5 participants
0